Skip to content

London | 26-ITP-May | Remi M. | Sprint 3 | Implement and Rewrite#1324

Open
remimarcelle wants to merge 6 commits into
CodeYourFuture:mainfrom
remimarcelle:coursework/sprint-3-implement-and-rewrite
Open

London | 26-ITP-May | Remi M. | Sprint 3 | Implement and Rewrite#1324
remimarcelle wants to merge 6 commits into
CodeYourFuture:mainfrom
remimarcelle:coursework/sprint-3-implement-and-rewrite

Conversation

@remimarcelle
Copy link
Copy Markdown

@remimarcelle remimarcelle commented May 22, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide
  • Run npm test from root - all tests pass
  • No console.assert errors in output
  • getCardValue throws errors for invalid inputs e.g. "invalid" and "1♠"
  • All 6 angle type cases covered including boundaries

Changelist

  • Implemented getAngleType, isProperFraction and getCardValue with JSDoc and console.assert tests
  • Rewrote all three sets of tests using Jest syntax covering normal, boundary and invalid cases

Questions

  • I used inline assertion style for exercises 2 and 3 and variable style for exercise 1 to match the existing example in the file - is there a preferred style?
  • For getCardValue I had to change slice(0, -2) to slice(0, -1) as the suit symbols were being read differently on Windows - is this the right fix?

@remimarcelle remimarcelle added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels May 22, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@remimarcelle
Copy link
Copy Markdown
Author

@github-actions

This comment has been minimized.

@remimarcelle remimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 22, 2026
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

1 participant